Make the ReactiveResilienceStrategy type-safe
#1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @vany0114 In your PR you have |
martincostello
approved these changes
Aug 8, 2023
Codecov Report
@@ Coverage Diff @@
## main #1462 +/- ##
==========================================
- Coverage 83.92% 83.89% -0.03%
==========================================
Files 274 276 +2
Lines 6506 6495 -11
Branches 1012 1015 +3
==========================================
- Hits 5460 5449 -11
Misses 837 837
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
One reoccurring complaint about the current non-generic core was the possibility of combining incompatible reactive strategies. This PR improves the API and makes the above not possible.
This was ensured with the following changes:
ReactiveResilienceStrategy<T>no longer derives fromResilienceStrategy.AddStrategyextensions for bothCompositeStrategyBuilderandCompositeStrategyBuilder<T>that require factory returningReactiveResilienceStrategy<T>.Going forward the author of custom resilience strategies can use:
ResilienceStrategyas a base class for non-reactive strategiesReactiveResilienceStrategy<T>as a base class for reactive strategiesContributes to #1454
Confirm the following